Rmw preallocate #51
Merged
Rmw preallocate #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
force-pushed
the
rmw_preallocate
branch
from
fd0f266
to
a27e824
Compare
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
force-pushed
the
rmw_preallocate
branch
from
a27e824
to
ee99d8f
Compare
clalancette
added
in review
clalancette
reviewed
Apr 30, 2019
There was a problem hiding this comment.
Two overall points:
- Do we need
RMW_INTERFACE_FN()forrmw_fini_{subscription,publisher}_allocation? If not, why not? - The order of arguments here will change if https://github.com/ros2/rmw/pull/160/files#r279917113 is accepted
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
clalancette
approved these changes
May 1, 2019
mm318
pushed a commit
to aws-ros-dev/rmw_implementation
that referenced
this pull request
May 2, 2019
* Add methods related to middleware preallocation. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Linting. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Adjust to new API. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Fixup. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Add allocator to `serialized_*` variants. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Adjust ordering and lint. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Add corresponding `fini` methods. Signed-off-by: Michael Carroll <michael@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#159