This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
set urdf content as parameter #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
added
question
|
This issue and the related PR for Rviz needs more information. The question to clarify here is whether the robot description should be a parameter in the first place or rather being published via topic. |
|
So the consensus was that it most likely makes sense to provide both, the topic and the parameter for the robot description and thus this PR can be set back to |
Karsten1987
added
in review
Works for me. |
clalancette
approved these changes
Mar 22, 2019
sloretz
approved these changes
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the loaded URDF as a parameter for the robot state publisher.