Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

Updates to publish robot model #9

Merged
merged 5 commits into from May 1, 2018
Merged

Conversation

bponsler
Copy link

@bponsler bponsler commented Aug 7, 2017

Simple changes to the robot state publisher to publish the robot model URDF as a std_msgs/String. This is to allow rviz, or other nodes, to access the robot model.

@bponsler
Copy link
Author

bponsler commented Aug 7, 2017

Note that I decided to publish the robot model (instead of write it as a parameter) for a few reasons:

  1. Publication support seems a little further along than parameters
  2. Easier support for a (potential future) dynamic robot model. Other nodes will receive model changes and not need to query for changes to the parameters
  3. Fastest way to get the robot model plugin working in rviz (probably the main reason, :) )

I also chose to duplicate the robot_model::initFile function so that I did not also have to make changes to two the robot_model repo. An improved solution would be to modify that function instead of having the separate copy (additionally, that would keep the file from being read twice).

@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Aug 23, 2017
@sloretz sloretz added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Jan 26, 2018
@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 1, 2018
@clalancette clalancette added this to the bouncy milestone Feb 22, 2018
Updated the robot state publisher to publish the robot model URDF as a std_msgs/String. This is to allow rviz, or other nodes, to access the robot model.
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I made a few fix ups and improved one of the error messages.

Sorry @bponsler that it took so long to add this. I was going back and forth on whether or not to add this and finally when we implemented it in the ros2/rviz repository, we added support of topic or parameter, so I opted to go ahead and include this for now.

Thanks for the contribution and sorry it sat so long.

@wjwwood
Copy link
Member

wjwwood commented May 1, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 1e13dd7 into ros2:ros2 May 1, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label May 1, 2018
@bponsler
Copy link
Author

bponsler commented May 2, 2018

Awesome! Thanks for pushing it over the finish line - glad it ended up being useful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants