Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Building a Visual Robot Model with URDF from Scratch" doesn't work on Foxy #2124

Closed
christophebedard opened this issue Nov 15, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@christophebedard
Copy link
Member

christophebedard commented Nov 15, 2021

https://docs.ros.org/en/foxy/Tutorials/URDF/Building-a-Visual-Robot-Model-with-URDF-from-Scratch.html

See https://answers.ros.org/question/390892/how-to-upgrade-launch_ros/

The urdf_tutorial repo/package has a launch file that uses ParameterValue from launch_ros: https://github.com/ros/urdf_tutorial/blob/09a5289c6cd7a6222a5538bcf77a09a73e251f76/launch/display.launch.py#L23.

However, it doesn't exist in Foxy (well, it exists, but as a type). See ros2/launch_ros#137

Since the urdf_tutorial repo only has a ros2 branch, a new foxy branch might need to be created to get a fix for Foxy (unless a temporary universal fix is applied to the ros2 branch until Foxy is EOL or something).

cc @DLu

@christophebedard
Copy link
Member Author

However, it doesn't exist in Foxy (well, it exists, but as a type). See ros2/launch_ros#137

This was just backported to Foxy in ros2/launch_ros#265, so this issue should be fixed whenever the next Foxy patch is released.

@clalancette clalancette added the bug Something isn't working label Dec 2, 2021
@clalancette clalancette added this to Proposed in Foxy Patch Release 7 via automation Dec 2, 2021
@DLu
Copy link
Contributor

DLu commented Dec 6, 2021

Can we close this as of the last sync?

@jacobperron jacobperron moved this from Proposed to Needs release in Foxy Patch Release 7 Jan 31, 2022
@jacobperron jacobperron moved this from Needs release to Done in Foxy Patch Release 7 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

3 participants