[foxy] Fix problems when parsing a Command Substitution as a parameter value (#137) #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix test_node_frontend Fix #145 1. Make test names more intelligible by not parameterizing on a crazy long string 2. Don't leak StringIO objects Signed-off-by: Dan Rose <dan@digilabs.io> * Some renamings and perform the same fixes on test_push_ros_namespace_frontend Signed-off-by: Dan Rose <dan@digilabs.io> * Remove incorrect docstring Signed-off-by: Dan Rose <dan@digilabs.io> * Add copyright for files with contributions Signed-off-by: Dan Rose <dan@digilabs.io> * Fix formatting Signed-off-by: Dan Rose <dan@digilabs.io> * Fix copyrights Signed-off-by: Dan Rose <dan@digilabs.io>
Invalid if type coerced using YAML rules. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
…alue (#137) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Address security bug in yaml loading Curate bug similar to ros/actionlib#171. Connected with aliasrobotics/RVD#2401. Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * revert one of the changes Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
I also had to backport #174 (dbb5a39) to resolve a test failure. |
|
CI together with ros2/launch#530:
|
jacobperron
added a commit
to ros2/ros2_documentation
that referenced
this pull request
Oct 26, 2021
Related to ros2/launch#530 and ros2/launch_ros#265 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
clalancette
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Oct 27, 2021
Related to ros2/launch#530 and ros2/launch_ros#265 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
@ros-pull-request-builder retest this please |
ivanpauno
approved these changes
Nov 16, 2021
jacobperron
added a commit
to ros2/ros2_documentation
that referenced
this pull request
Feb 7, 2022
* Note launch behavior change in Foxy Patch 7 Related to ros2/launch#530 and ros2/launch_ros#265 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix link syntax Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Minor fixes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
mergify bot
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Feb 7, 2022
* Note launch behavior change in Foxy Patch 7 Related to ros2/launch#530 and ros2/launch_ros#265 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix link syntax Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Minor fixes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit dc0ddb4)
mergify bot
pushed a commit
to ros2/ros2_documentation
that referenced
this pull request
Feb 7, 2022
* Note launch behavior change in Foxy Patch 7 Related to ros2/launch#530 and ros2/launch_ros#265 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix link syntax Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Minor fixes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit dc0ddb4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #146, #164, and #137 to Foxy. The first two commits are prerequisites for #137.
Backport #175 to fix CI.
Fixes #214
Depends on ros2/launch#530