Include xml and yaml launch files in examples #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase this onto the latest? Thanks. |
Add examples on including XML and YAML files in Python/XML/YAML launch files Related to ros2#3369 Signed-off-by: Damien LaRocque <phicoltan@gmail.com>
IamPhytan
force-pushed
the
damien/update-launch-file-different-formats
branch
from
b4ecede
to
8876334
Compare
|
Yes, I rebased onto 01e1968. |
clalancette
requested changes
Mar 10, 2023
Imports were scrambled in the launch file, corrected the order Signed-off-by: Damien LaRocque <phicoltan@gmail.com>
clalancette
approved these changes
Mar 10, 2023
|
You're welcome ! Glad to have contributed to a small bit of ROS2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the YAML launch files that were added with a pull request in
ros2/demos.Related to #3369