Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QD draft for Boost exernal dependency #551

Closed
wants to merge 1 commit into from

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Mar 5, 2020

This is a quality declaration for Boost libraries, considered an external dependency of class_loader package. REP-2004 (see ros-infrastructure/rep#218) establishes that external dependencies have to be quality level 1, for the ROS package using them to be considered of that same level.

External dependencies do not have a defined set of parameters to be evaluated to be considered to be Quality level 1. However, this PR aims to start discussing the best way to make this statement in a standard way or deciding if the external dependencies require a more qualitative approach.

Signed-off-by: Jorge J. Perez jjperez@ekumenlabs.com

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Contributor Author

Blast545 commented Mar 5, 2020

Closing it here, to open it as part of class_loader.

@dirk-thomas
Copy link
Member

considered an external dependency of class_loader package

I assume we are referring to ROS 2 here and in that case I think the statement is incorrect. class_loader doesn't depend on boost in ROS 2 afaik.

@Blast545
Copy link
Contributor Author

Blast545 commented Mar 5, 2020

@dirk-thomas Yes, you are right. I realized that when I was moving the description to the class_loader repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants