add unit tests #14
add unit tests #14
Conversation
|
|
||
| count = 0 | ||
| for package_name in package_names: | ||
| package_cmd = ['ros2', 'msg', 'package', package_name] |
There was a problem hiding this comment.
I didn't notice this verb before. It looks strange to me, since package is not a verb in this context. I would have expected something more like ros2 msg list --package <pkg> or ros2 msg list --only-package <pkg>. I know that's not part of this pr, but I think it probably should be changed in a follow up pr.
Related to this is the ros2 msg packages command, which reads ok, but again is not a verb. I think ros2 msg list_packages or ros2 msg list-packages or ros2 msg list --packages.
There was a problem hiding this comment.
The same applies to ros2 srv package[s] verbs.
@ros2/team can you guys weigh in on this? Do you prefer ros2 msg package <pkg> or ros2 msg list --package <pkg> (also ros2 msg packages vs. ros2 msg list --packages)?
If the consensus is that the alternative verb names I proposed would be better, then I'll open a pr to update the commands later.
There was a problem hiding this comment.
The advantage I saw with having separate "verbs" is that each of them is self contained. Additional ones can easily be added (without fiddling with existing code, e.g. by external Python packages). Also with a single "verb" handling multiple different cases you have to "read" the usage to figure out which option can be used together with others and how it might affect the output (e.g. the --packages and --package options would be mutually exclusive).
|
I will go ahead and merge these tests. Please continue the conversation / reply to @wjwwood question. |
* Give more info when output is not in expected sequence
* Real captured output has newline in it. Update test data to reflect
* Fix exception with process name resolution, add test
* Add infrastructure to coordinate ROS_DOMAIN_IDs between apex_launchtest processes
* Isolate tests with ROS_DOMAIN_ID by default
* Address PR comments
* Fix style
- Defaults in the docker image we run the test in changed. We're now failing for style
reasons. Mostly need to re-order imports and change " quotes to '
* apex_launchtest_ros add better example
- Fix up style issues
- Typo
- Update apex_launchtest_ros/examples/README.md
- Formatting
- formatting
- Fix bad spelling
- Improve sentence
- Fix Typo
* Improve apex launchtest ros
- Add the parametrization infrastrcture
- Refactor the apex runner into an ApexRunner and a RunnerWorker
- This veresion should still run existing tests. This is mostly a refactor commit
* Refactor to allow for parametrized launch descriptions
- Combine pre and post results into one set of results, add class names so the tests
are distinguishable
- Update tests to match new 'run' API that returns a dictionary of {test_run: result} instead
of a tuple of (pre_shutdown, post_shutdown) results
* Add parametrized example, finish refactor
* Beef up test coverage for new features
* Push changes into apex_rostest subdirectory.
* Prune unnecesary files.
Co-Authored-By: pbaughman <dblue135@yahoo.com>
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Ready for review.