Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check in action module if action service #163

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Check in action module if action service #163

merged 1 commit into from
Dec 6, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Dec 6, 2018

Like 417d46f but for services. This imports the service type from .action if the service name indicates it's an action service.

To manually test:

  1. Checkout Rclcpp action examples examples#220
  2. run the server 
    ros2 run examples_rclcpp_minimal_action_server action_server_not_composable
  3. try to call the send goal service 
    ros2 service call /fibonacci/_action/send_goal example_interfaces/Fibonacci_Goal
  4. try to call the get result service 
    ros2 service call /fibonacci/_action/get_result example_interfaces/Fibonacci_Result

@sloretz sloretz added the in review Waiting for review (Kanban column) label Dec 6, 2018
@sloretz sloretz added this to the crystal milestone Dec 6, 2018
@sloretz sloretz self-assigned this Dec 6, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Dec 6, 2018

CI (testing only ros2service for linters)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 6d5dff7 into master Dec 6, 2018
@sloretz sloretz deleted the service_call_action_services branch December 6, 2018 22:04
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Dec 6, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
@ivanpauno
Add a way to set remapping rules for all nodes in the same scope (ros…
70c9a8d 
…2#163)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
crystal
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @mjcarroll