fix ros2 lifecycle get #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
Karsten1987
approved these changes
Dec 11, 2018
|
CI (testing only package ros2lifecycle for linters)
|
|
The linters passed locally. So I don't think we need to run CI builds on four platforms - especially for such a minimal change. |
|
I will go ahead and merge this to allow #174 to move forward. |
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Emits events.ExecutionComplete on Action completion. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Makes LaunchTestService handle non-process actions. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Makes LaunchTestService handle fixture process actions. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Adds output checks to LaunchTestService. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Updates launch_testing package tests. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Applies fixes after launch_testing refactor. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Adds OpaqueCoroutine action subclass. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Apply suggestions from code review Co-Authored-By: hidmic <michel@ekumenlabs.com> * Addresses peer review comments. - Emit ExecutionComplete events on demand. - Shutdown OpaqueCoroutine gracefully. - Fix failing test cases. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Refactors launch_testing API a bit. To cope with more test cases. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Applies style fixes to launch_testing. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Deal with non zero exit on shutdown. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Avoids output tests' races. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Applies misc fixes after Windows triaging. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Applies more fixes after Windows triaging. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Fixes linter issue. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Addresses peer review comments. - Improved OpaqueCoroutine documentation. - Added test for launch.event_handlers.OnExecutionComplete. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166.