Remove unused cli option #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Karsten1987
force-pushed
the
remove_unused_cli_option
branch
from
16fc599
to
f13be2b
Compare
dirk-thomas
approved these changes
Dec 12, 2018
dirk-thomas
reviewed
Dec 12, 2018
| @@ -47,9 +43,13 @@ def main(self, *, args): # noqa: D102 | |||
| node_names = [n.full_name for n in node_names] | |||
|
|
|||
| if args.node_name: | |||
| if args.node_name not in node_names: | |||
| node_name = args.node_name | |||
| if not node_name[0] == '/': | |||
There was a problem hiding this comment.
Nitpick: node_name[0] != '/'
Merged
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Support required nodes
Currently, the only way to specify that a given node is required for a
given `LaunchDescription` is to register an `OnProcessExit` handler for
the exit event of the required node that then emits a `Shutdown` event.
Instead of requiring this boilerplate for a common use-case, add an
`on_exit` parameter to `ExecuteProcess` that can take actions, and add a
new action called `Shutdown` that immediately causes the launched system
to shut down. This allows for the concept of a required node to be
expressed simply with:
launch_ros.actions.Node(
# ...
on_exit=Shutdown()
)
Resolve ros2#174
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
* Inherit from EmitEvent
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
* Properly align type
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
* Expose reason
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Asynchronously wait for load node service response Fixes ros2#171 By asychronously waiting for the service response, we can monitor if launch is shutting down and abandon the request so we don't block the shutdown process. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add back debug log It was accidentally removed. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #170
has to be rebased when #167 is merged.
This PR basically removed the obsolete argument
--transitionsfor theros2 lifecycle getcommand. The transitions can be displayed by invokingros2 lifecycle list [-a] <node_name>