Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2lifecycle] get --transitions raises AttributeError #170

Closed
sloretz opened this issue Dec 11, 2018 · 1 comment · Fixed by #174
Closed

[ros2lifecycle] get --transitions raises AttributeError #170

sloretz opened this issue Dec 11, 2018 · 1 comment · Fixed by #174
Assignees
Labels
bug Something isn't working

Comments

@sloretz
Copy link
Contributor

sloretz commented Dec 11, 2018

Bug report

Required Info:

  • Operating System:
    • ubuntu bionic
  • Installation type:
    • debs
  • Version or commit hash:
    • crystal pre-release
  • DDS implementation:
    • Fast-RTPS
  • Client library (if applicable):
    • rclpy

Steps to reproduce issue

  1. Start a lifecycle node
    ros2 run lifecycle lifecycle_talker
    
  2. List available transitions for the node
    ros2 lifecycle get --transitions  /lc_talker
    

Expected behavior

I expect to see a list of transitions the node could go through.

Actual behavior

$ ros2 lifecycle get --transitions  /lc_talker
unconfigured [1]
Traceback (most recent call last):
  File "/opt/ros/crystal/bin/ros2", line 11, in <module>
    load_entry_point('ros2cli==0.6.1', 'console_scripts', 'ros2')()
  File "/opt/ros/crystal/lib/python3.6/site-packages/ros2cli/cli.py", line 69, in main
    rc = extension.main(parser=parser, args=args)
  File "/opt/ros/crystal/lib/python3.6/site-packages/ros2lifecycle/command/lifecycle.py", line 40, in main
    return extension.main(args=args)
  File "/opt/ros/crystal/lib/python3.6/site-packages/ros2lifecycle/verb/get.py", line 93, in main
    .format_map(locals()))
AttributeError: 'TransitionDescription' object has no attribute 'label'

Additional information

@sloretz sloretz added the bug Something isn't working label Dec 11, 2018
@Karsten1987
Copy link
Contributor

I feel like this option should be disabled.

in order to only currently available transitions:

ros2 lifecycle list /lc_talker

In order to see all available transitions:

ros2 lifecycle list -a /lc_talker

Does this make sense?

@Karsten1987 Karsten1987 self-assigned this Dec 11, 2018
@Karsten1987 Karsten1987 added the in progress Actively being worked on (Kanban column) label Dec 11, 2018
@Karsten1987 Karsten1987 removed the in progress Actively being worked on (Kanban column) label Dec 12, 2018
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
* OnProcessExit correct typing for Callable

Signed-off-by: Shane Loretz<sloretz@openrobotics.org>

* Line length
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
Fixes ros2#114.

Due to the asynchronous nature of the LoadComposableNodes action, an event handler causes the launch configuration is popped if ComposableNodeContainer appears inside a group or include action.
It seems to me we can simply return the load node action, which will get executed after the ComposableNodeContainer action. The use of an event handler is vestigial of a refactoring done in ros2/launch_ros#16, and doesn't appear to be necessary.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants