Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xmllint linter test #232

Merged
merged 2 commits into from
May 3, 2019
Merged

add xmllint linter test #232

merged 2 commits into from
May 3, 2019

Conversation

mikaelarguedas
Copy link
Member

Similar to ros2/rosidl_python#53.

Maybe there is a better way of doing this? is there something like ament_lint_common for python packages?

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 2, 2019
@dirk-thomas
Copy link
Member

dirk-thomas commented May 2, 2019

Thanks for the improvement.

is there something like ament_lint_common for python packages?

Not at the moment but there could be.

We will likely wait with running CI until after today's API freeze.

@dirk-thomas
Copy link
Member

Thanks for the patch.

Build Status

@dirk-thomas dirk-thomas merged commit fe768be into ros2:master May 3, 2019
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label May 3, 2019
@mikaelarguedas mikaelarguedas deleted the xmllint branch May 3, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants