Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2topic] Handle multiple namespace parts in message type #237

Merged
merged 3 commits into from
May 15, 2019

Conversation

jacobperron
Copy link
Member

Fixes #235.
Now the 'bw', 'hz', and 'delay' verbs work again.

Fixes #235.
Now the 'bw', 'hz', and 'delay' verbs work again.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 15, 2019
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member

Now the 'bw', 'hz', and 'delay' verbs work again.

Certainly a nice improvement ;)

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron merged commit 52b5a70 into master May 15, 2019
@jacobperron jacobperron deleted the jacob/fix235 branch May 15, 2019 21:43
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label May 15, 2019
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ros2topic] 'The passed message type is invalid'
3 participants