use three-part interface names in msg/srv/action show and msg/srv/ list #259
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
dirk-thomas
changed the title
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/three-part-interface-names
branch
from
e93087d
to
9d2d393
Compare
jacobperron
approved these changes
May 23, 2019
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
…#259) * Support both param file configurations in to_parameters_list.py Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Support another file config and add tests Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Update to work for multiple entries in yaml Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Fix deleted line Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Remove duplicated line Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Address reviewer comments Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Emit warning iff no node name and ros__parameters foramt is used Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor after review - Rename private function for dealing with ros__parameters entries - Keep recursive parameters internal to function - Skip evaluating parameters if dictionary is empty - Use isinstance - Strip trailing and leading '/' from node namespace Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove unnecessary line Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Reset keys list in case of dictionary value We actually do this for the case of multiple entries like this: /ns_1: /node_1: ros__parameters: param_1: 1 param_2: 2 /**: ros__parameters: param_2: 22 param_3: 33 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Use separate test file for test_load_composable_nodes Rather than reusing the test file that is used in test_node. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255 and fixes #257.