Better error message for ros2 action show #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch a potential error when splitting the input string. This is how it is done for 'ros2 msg show' and 'ros2 srv show'. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Shouldn't this operate on 3-part names? |
|
Right now, none of the |
|
I think because things related to the ament resource index haven't been updated, we have to ignore the middle part for showing purposes. |
dirk-thomas
added
bug
dirk-thomas
added
in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch a potential error when splitting the input string.
This is how it is done for 'ros2 msg show' and 'ros2 srv show'.