add exec_depend on python3-pkg-resources #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Jun 28, 2017
| @@ -9,6 +9,7 @@ | |||
| <maintainer email="dthomas@osrfoundation.org">Dirk Thomas</maintainer> | |||
| <license>Apache License 2.0</license> | |||
|
|
|||
| <exec_depend>python3-pkg-resources</exec_depend> | |||
There was a problem hiding this comment.
Is this only a run dependency? Is it not already used at buildtime?
There was a problem hiding this comment.
I thought that ament_python packages rely on setuptools at buildtime that provide this dependency. So I assumed that runtime would be enough, isn't it ?
There was a problem hiding this comment.
Ok, I think that is fine for now with the setuptools dependency being injected by bloom.
There was a problem hiding this comment.
Sounds good merging as is then
dirk-thomas
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rosdep key has been added in ros/rosdistro#15406