Add service call prototype completer #300
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artivis
force-pushed
the
feature/service-call-prototype-completer
branch
2 times, most recently
from
f3e4dc7
to
691f115
Compare
artivis
force-pushed
the
feature/service-call-prototype-completer
branch
2 times, most recently
from
b85e04c
to
e623ffc
Compare
ivanpauno
reviewed
Aug 2, 2019
| parts = full_service_type.split('/') | ||
| package_name = parts[0] | ||
| interface_type = parts[1] | ||
| service_type = parts[-1] |
There was a problem hiding this comment.
Same comment as at #301 (comment).
Signed-off-by: artivis <jeremie.deray@canonical.com>
artivis
force-pushed
the
feature/service-call-prototype-completer
branch
from
e623ffc
to
a345e63
Compare
|
@ivanpauno updated the PR to benefit from ros2/rosidl_python#78 |
ivanpauno
approved these changes
Aug 7, 2019
|
Sanity check:
|
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
If a substitution evaluates to the empty string, then yaml.safe_load() will return None, resulting in an exception being raised. Instead, this commit allows for the empty string by first wrapping it in an extra set of quotes before passing to yaml.safe_load(). Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a service request prototype completer to
ros2 service call.E.g.
Not very pretty but one can at least figure out the first few characters of the request body.
Then,
resolves to,
This follows the work initiated in #298.
Signed-off-by: artivis jeremie.deray@canonical.com