Add action send_goal prototype completer #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artivis
force-pushed
the
feature/action-send-goal-proto-completer
branch
from
4bc829a
to
09f6a08
Compare
artivis
force-pushed
the
feature/action-send-goal-proto-completer
branch
2 times, most recently
from
44cff92
to
cf4649b
Compare
ivanpauno
reviewed
Aug 2, 2019
This was referenced Aug 2, 2019
artivis
force-pushed
the
feature/action-send-goal-proto-completer
branch
from
cf4649b
to
553b9b5
Compare
|
@ivanpauno I'll wait on your feedback and final approval of this PR before updating #299 & #300. |
dirk-thomas
reviewed
Aug 2, 2019
artivis
force-pushed
the
feature/action-send-goal-proto-completer
branch
2 times, most recently
from
6fb5b87
to
cea6e59
Compare
ivanpauno
reviewed
Aug 5, 2019
artivis
force-pushed
the
feature/action-send-goal-proto-completer
branch
2 times, most recently
from
1b2bea4
to
421cba8
Compare
ivanpauno
approved these changes
Aug 6, 2019
@artivis There's a linter failure, could you address it? Thanks! |
Sure thing ! |
Signed-off-by: artivis <jeremie.deray@canonical.com>
artivis
force-pushed
the
feature/action-send-goal-proto-completer
branch
from
421cba8
to
1eeba50
Compare
|
@ivanpauno Should be fixed now. |
I tested locally, and linter is passing (and auto-completion continues working well). |
|
@artivis another minimal comment: try to avoid force pushing if it's not completely necessary, it does the review process harder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an action goal prototype completer to
ros2 action send_goal.E.g.
Not very pretty but one can at least figure out the first few characters of the goal body.
Then,
resolves to,
This follows the work initiated in #298.
Signed-off-by: artivis jeremie.deray@canonical.com