Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interface type completer does not include actions #302

Closed
artivis opened this issue Jul 18, 2019 · 0 comments · Fixed by #303
Closed

interface type completer does not include actions #302

artivis opened this issue Jul 18, 2019 · 0 comments · Fixed by #303

Comments

@artivis
Copy link
Contributor

artivis commented Jul 18, 2019

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • source
  • Version or commit hash:
  • DDS implementation:
    • Fast-RTPS
  • Client library (if applicable):
    • rclpy

Steps to reproduce issue

$ ros2 interface show example_interfaces [tab][tab]

Expected behavior

$ ros2 interface show example_interfaces/
example_interfaces/action/Fibonacci  example_interfaces/srv/AddTwoInts

Actual behavior

Auto-complete directly to:

$ ros2 interface show example_interfaces/srv/AddTwoInts

Additional information

Actions are simply not handled in api/_init_.py:l56:type_completer.
artivis added a commit to artivis/ros2cli that referenced this issue Jul 18, 2019
@artivis
add actions to interface type completer
4027107 
  Fix ros2#302

Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis mentioned this issue Jul 18, 2019
Merged
@artivis artivis changed the title interface completer does not include actions interface type completer does not include actions Jul 18, 2019
jacobperron pushed a commit that referenced this issue Jul 19, 2019
@artivis @jacobperron
add actions to interface type completer (#303)
96c9ff2 
Fix #302

Signed-off-by: artivis <jeremie.deray@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add actions to interface type completer artivis/ros2cli
1 participant
@artivis