Add actions to interface type completer #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ros2#302 Signed-off-by: artivis <jeremie.deray@canonical.com>
jacobperron
approved these changes
Jul 19, 2019
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
…nodes (ros2#303) * When resolving parameters from a file, use the full node namespace, combined with any base namespace provided by launch (e.g. from PushRosNamespace). * Handle edge case in 'to_parameters_list', when namespace equals '/'. * Fix bug in test fixture returning invalid node names that contain consecutive forward slashes. * Add tests to cover cases for loading parameters from file when namespace is provided by PushRosNamespace actions. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #302
Signed-off-by: artivis jeremie.deray@canonical.com