ros2interface fixes/changes #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For node name order to be deterministic. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
…of 'use_sim_time' parameter. (#307) Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com> Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
skucheria
force-pushed
the
kucheria_interface_revisions
branch
from
083b586
to
c1d3b54
Compare
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
dirk-thomas
reviewed
Jul 30, 2019
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
skucheria
force-pushed
the
kucheria_interface_revisions
branch
from
2d931db
to
da9c496
Compare
|
After making changes to the PR please comment on the ticket - otherwise there is no notification email sent so it won't be looked at again. |
dirk-thomas
approved these changes
Aug 8, 2019
Should I run CI for these changes or is it good to go? |
Your call. If you are very confident it passes cleanly across all platforms you can go ahead without. The safer bet would be to run CI for the affected packages to make sure it does. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comments: #288 (comment)