Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2interface]: "interface list" verb doesn't display intermediate directory #382

Closed
clalancette opened this issue Oct 23, 2019 · 5 comments · Fixed by ros2/rosidl_runtime_py#6
Closed

[ros2interface]: "interface list" verb doesn't display intermediate directory #382

clalancette opened this issue Oct 23, 2019 · 5 comments · Fixed by ros2/rosidl_runtime_py#6
Assignees
@jacobperron
Labels
bug Something isn't working
Projects
Eloquent

Comments

@clalancette
Copy link
Contributor

If I run ros2 msg list, I get a (heavily edited) output that looks like:

turtlesim/msg/Color
turtlesim/msg/Pose

If I run ros2 interface list, I get a (heavily edited) output that looks like:

Messages:
    turtlesim/Color
    turtlesim/Pose

While the "Messages" category is explicit that these are messages, I think that it would be best to be consistent here and always print the "intermediate" msg here.
@dirk-thomas dirk-thomas added this to To do in Eloquent via automation Oct 23, 2019
@jacobperron jacobperron added the bug Something isn't working label Oct 24, 2019
@jacobperron jacobperron self-assigned this Oct 24, 2019
@jacobperron
Copy link
Member

This actually due to a bug in the rosidl_runtime_py functions being called by the list verb.

jacobperron added a commit to ros2/rosidl_runtime_py that referenced this issue Oct 24, 2019
@jacobperron
Do not remove interface namespaces
4ea56fd 
For example, we want the full name of the message 'turtlesim/msg/Pose' and not 'turtlesim/Pose'.

Fixes ros2/ros2cli#382

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this issue Oct 24, 2019
Merged
@jacobperron
Copy link
Member

See ros2/rosidl_runtime_py#6 for a fix.

@jacobperron jacobperron added the in review Waiting for review (Kanban column) label Oct 24, 2019
@jacobperron
Copy link
Member

Consequently, this also fixes a similar issue with completion for the show verb.

Eloquent automation moved this from To do to Done Oct 24, 2019
@wuffle-ros wuffle-ros bot removed the in review Waiting for review (Kanban column) label Oct 24, 2019
jacobperron added a commit to ros2/rosidl_runtime_py that referenced this issue Oct 24, 2019
@jacobperron
Do not remove interface namespaces (#6)
43dde52 
For example, we want the full name of the message 'turtlesim/msg/Pose' and not 'turtlesim/Pose'.

Fixes ros2/ros2cli#382

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@hidmic
Copy link
Contributor

hidmic commented Oct 24, 2019

As I said on ros2/rosidl_runtime_py#6, I think ros2interface tests have not been properly updated :)

@jacobperron
Copy link
Member

As I said on ros2/rosidl_runtime_py#6, I think ros2interface tests have not been properly updated :)

Good catch, my bad. I should have included ros2interface in the CI build...

See #386 for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobperron jacobperron

Labels
bug Something isn't working
Projects
No open projects
Eloquent
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not remove interface namespaces ros2/rosidl_runtime_py
3 participants
@clalancette @jacobperron @hidmic