Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2interface] Fix tests #386

Merged
merged 1 commit into from
Oct 25, 2019
Merged

[ros2interface] Fix tests #386

merged 1 commit into from
Oct 25, 2019

Conversation

jacobperron
Copy link
Member

Broken in ros2/rosidl_runtime_py#6

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@jacobperron jacobperron merged commit 1d34247 into master Oct 25, 2019
@wuffle-ros wuffle-ros bot removed the in review Waiting for review (Kanban column) label Oct 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix_test branch October 25, 2019 00:00
@dirk-thomas
Copy link
Member

The CI build of this PR still has one failing test related to ros2interface.

@jacobperron
Copy link
Member Author

The CI build of this PR still has one failing test related to ros2interface.

@dirk-thomas If you are referring to the PR job, it's because behavior was changed in ros2/rosidl_runtime_py#6 (which hasn't been released yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants