Avoid passing None to rclpy.init #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, all CLI arguments will be parsed as ROS arguments, which can lead to rcl warnings or incorrect legacy remapping behavior. This change does not pass arguments to rclpy.init from any of the CLI tools, but it leaves the opportunity to do so in the future by setting the parser argument 'argv'. For example, we could take the remaining arguments and pass them to rclpy.init, similar to what is done in ros2run: https://github.com/ros2/ros2cli/blob/4c5d9327026ecb2ea10a16b3429908b4f6f64ca6/ros2run/ros2run/command/run.py#L51-L53 Fixes #336. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
sloretz
approved these changes
Jan 14, 2020
|
@jacobperron from pre-waffle can you retrigger CI? |
sloretz
pushed a commit
that referenced
this pull request
Feb 6, 2020
Otherwise, all CLI arguments will be parsed as ROS arguments, which can lead to rcl warnings or incorrect legacy remapping behavior. This change does not pass arguments to rclpy.init from any of the CLI tools, but it leaves the opportunity to do so in the future by setting the parser argument 'argv'. For example, we could take the remaining arguments and pass them to rclpy.init, similar to what is done in ros2run: https://github.com/ros2/ros2cli/blob/4c5d9327026ecb2ea10a16b3429908b4f6f64ca6/ros2run/ros2run/command/run.py#L51-L53 Fixes #336. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Feb 9, 2020
Otherwise, all CLI arguments will be parsed as ROS arguments, which can lead to rcl warnings or incorrect legacy remapping behavior. This change does not pass arguments to rclpy.init from any of the CLI tools, but it leaves the opportunity to do so in the future by setting the parser argument 'argv'. For example, we could take the remaining arguments and pass them to rclpy.init, similar to what is done in ros2run: https://github.com/ros2/ros2cli/blob/4c5d9327026ecb2ea10a16b3429908b4f6f64ca6/ros2run/ros2run/command/run.py#L51-L53 Fixes #336. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, all CLI arguments will be parsed as ROS arguments, which can lead
to rcl warnings or incorrect legacy remapping behavior.
This change does not pass arguments to rclpy.init from any of the CLI
tools, but it leaves the opportunity to do so in the future by setting the
parser argument 'argv'. For example, we could take the remaining arguments
and pass them to rclpy.init, similar to what is done in ros2run:
ros2cli/ros2run/ros2run/command/run.py
Lines 51 to 53 in 4c5d932
Fixes #336.