Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect EXPORT for executables #545

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Conversation

dirk-thomas
Copy link
Member

Fixes #543.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas merged commit 8d24ba2 into master Jul 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-543 branch July 1, 2020 16:15
dirk-thomas added a commit that referenced this pull request Jul 6, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas added a commit that referenced this pull request Jul 6, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
nuclearsandwich pushed a commit that referenced this pull request Jul 10, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
craigh92 pushed a commit to craigh92/ros2cli that referenced this pull request Jul 17, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Craig Hickman <craig.hickman@ukaea.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ros2 pkg create] Exporting executable target can cause issues with ament_target_dependencies
2 participants