Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2interface] Fixes inline comments for constants #548

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

audrow
Copy link
Member

@audrow audrow commented Jun 30, 2020

Previously, inline comments on constants were not able to be removed; now they adopt the same display behavior as other comments.

@audrow audrow added the bug Something isn't working label Jun 30, 2020
@audrow audrow added this to Proposed in Foxy Patch Release 1 via automation Jun 30, 2020
Signed-off-by: Audrow <audrow.nash@gmail.com>
@audrow audrow force-pushed the audrow/fix-inline-comments-for-constants branch from 25824b7 to fd4fcc7 Compare July 1, 2020 17:39
@audrow
Copy link
Member Author

audrow commented Jul 1, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow audrow merged commit dda7a7f into master Jul 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the audrow/fix-inline-comments-for-constants branch July 1, 2020 21:04
@jacobperron jacobperron removed this from Proposed in Foxy Patch Release 1 Jul 10, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 2 via automation Jul 10, 2020
craigh92 pushed a commit to craigh92/ros2cli that referenced this pull request Jul 17, 2020
Signed-off-by: Audrow <audrow.nash@gmail.com>
Signed-off-by: Craig Hickman <craig.hickman@ukaea.uk>
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 2 Jul 22, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 2 Jul 22, 2020
@audrow audrow added this to Proposed in Foxy Patch Release 2 via automation Jul 22, 2020
@audrow audrow removed this from Proposed in Foxy Patch Release 2 Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants