Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linters for helpers.py and ros2node/api/__init__.py #808

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Crola1702
Copy link
Contributor

Linux debug CI shows test regressions with test_flake8:

Reference build: Linux Debug #2589

ros2cli.ros2cli.test.test_flake8.test_flake8

test/test_flake8.py:23: in test_flake8
    assert rc == 0, \
E   AssertionError: Found 1 code style errors / warnings:
E     ./ros2cli/helpers.py:46:1: E302 expected 2 blank lines, found 1
E   assert 1 == 0

ros2node.ros2node.test.test_flake8.test_flake8

test/test_flake8.py:23: in test_flake8
    assert rc == 0, \
E   AssertionError: Found 2 code style errors / warnings:
E     ./ros2node/api/__init__.py:15:1: F401 'time' imported but unused
E     ./ros2node/api/__init__.py:17:1: I100 Import statements are in the wrong order. 'from collections import namedtuple' should be before 'import time'
E   assert 1 == 0

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@mjcarroll
Copy link
Member

Duplicate of #807 (or vice-versa, they were opened at the same time!)

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

The failing tests on Linux are a separate problem. This looks like it fixes the flake8 issues, so going ahead and merging it. Thanks @Crola1702 !

@clalancette clalancette merged commit 14e640c into rolling Feb 27, 2023
@clalancette clalancette deleted the Crola1702/fix-ros2node-ros2cli-linters branch February 27, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants