[eloquent] [ros2action] Deprecate show verb #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #363, as we've consolidated interface CLI logic to ros2interface. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Related PR removing this verb for Foxy: #405 |
jacobperron
changed the title
|
Why remove all the tests? |
they were failing because of the deprecation warning. |
|
Updating the tests to still pass would be better to avoid that the command regresses in Eloquent. |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/deprecate_action_show
branch
from
2c90e31
to
c5b5f8a
Compare
Good point. I've updated the tests instead (c5b5f8a). |
dirk-thomas
approved these changes
Dec 3, 2019
|
mjcarroll
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #363, as we've consolidated interface CLI logic to ros2interface.