Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make ros2param use rclpy.parameter_client #716

Merged
merged 17 commits into from
Jul 22, 2022
Merged

refactor: make ros2param use rclpy.parameter_client #716

merged 17 commits into from
Jul 22, 2022

Commits on Jul 22, 2022

  1. move get_parameter_value to rclpy 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    166582c View commit details
    Browse the repository at this point in the history

  2. refactor: use exisiting list_parameters method 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    ee2cb61 View commit details
    Browse the repository at this point in the history

  3. refactor: use latest api from rclpy.parameter_client 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    5ee3fdd View commit details
    Browse the repository at this point in the history

  4. wait on service ready 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    b81238e View commit details
    Browse the repository at this point in the history

  5. refactor: use api 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    8c46df2 View commit details
    Browse the repository at this point in the history

  6. add wait_for_service 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    3ea38f0 View commit details
    Browse the repository at this point in the history

  7. revert timeout_sec 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    1f2c3cc View commit details
    Browse the repository at this point in the history

  8. fix tests 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    982edd9 View commit details
    Browse the repository at this point in the history

  9. bump test timeout 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    e7ef792 View commit details
    Browse the repository at this point in the history

  10. don't busy wait 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    6c2bf7f View commit details
    Browse the repository at this point in the history

  11. only make one get_parameter_value call in ros2 param dump 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    efd6bee View commit details
    Browse the repository at this point in the history

  12. raise error if wait_for_service times out 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    fa6009e View commit details
    Browse the repository at this point in the history

  13. use hanging indent & more descriptive error message 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    e752244 View commit details
    Browse the repository at this point in the history

  14. gracefully handle nodes that do not provide parameter services 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    582428a View commit details
    Browse the repository at this point in the history

  15. Revert "bump test timeout" 

    This reverts commit 20ba9fe.

Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie
    ihasdapie committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    f3b5c11 View commit details
    Browse the repository at this point in the history

  16. Update ros2param/ros2param/api/__init__.py 

    Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @jacobperron
    ihasdapie and jacobperron committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    821f0f2 View commit details
    Browse the repository at this point in the history

  17. Update ros2param/ros2param/verb/dump.py 

    Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @jacobperron
    ihasdapie and jacobperron committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    8d271ce View commit details
    Browse the repository at this point in the history