Fix list_priorities.py for configs which use !include tags. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
pushed a commit
that referenced
this pull request
Dec 28, 2020
* Update the buildfarm config with the new gpg keys.
This file, introduced in #120, causes the script to fail since it contains a YAML string scalar rather than dict. Even after this commit the script fails due to the include block in rolling/ci-benchmark.yaml so that needs to be dealt with for this PR to move forward. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
nuclearsandwich
force-pushed
the
priorities-not-included
branch
from
9e7cc99
to
c8a3804
Compare
nuclearsandwich
changed the title
|
This PR is really old, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file, introduced in #120, causes the script to fail since it
contains a YAML string scalar rather than dict.
Even after this commit the script fails due to the include block in
rolling/ci-benchmark.yaml so that needs to be dealt with for this PR to
move forward. The easiest way would be to find a way to ignore the include since currently the priority field is not behind an include.
A cherry on top of this PR would be adding a GitHub Action which runs priority list on PRs which would also keep the script working.
FYI @cottsay