Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for broken RHEL-8 build #1104

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Fix for broken RHEL-8 build #1104

merged 1 commit into from
Sep 28, 2022

Conversation

MichaelOrlov
Copy link
Contributor

Follow up to the #1098 (comment)
RHEL-8 build fails due to the lack of adequate support for std::filesystem::path(..) on RHEL-8

Replaced std::filesystem::path(..) with rcpputils::fs::path(..) in split_bag_metadata_has_full_duration unit test.

@MichaelOrlov
Replace std::filesystem::path(..) with rcpputils::fs::path(..)
1c66284 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner September 28, 2022 07:02
@MichaelOrlov MichaelOrlov requested review from gbiggs, hidmic and clalancette and removed request for a team September 28, 2022 07:02
@MichaelOrlov MichaelOrlov mentioned this pull request Sep 28, 2022
Merged
@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/d5e11603d9dd65ec7134449c732f69cd/raw/6318e5641ae6925b85d1f099dabf7cda959d1202/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp
TEST args: --packages-above rosbag2_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10902

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

@ros-pull-request-builder retest this please

clalancette
clalancette approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelOrlov Thank you so much for doing this! This looks good to me (even with the Rpr job failing, that is a known flake).

@MichaelOrlov MichaelOrlov merged commit 6de3611 into rolling Sep 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the morlov/fix_for_broken_rhel-8_build branch September 28, 2022 16:05
@emersonknapp
Copy link
Collaborator

Thanks @MichaelOrlov for taking care of this

@MichaelOrlov
Copy link
Contributor Author

https://github.com/Mergifyio backport humble

@mergify
Copy link

mergify bot commented Apr 12, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 12, 2023
@MichaelOrlov @mergify
Replace std::filesystem::path(..) with rcpputils::fs::path(..) (#…
06ed342 
…1104)

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 6de3611)
@mergify mergify bot mentioned this pull request Apr 12, 2023
Merged
MichaelOrlov added a commit that referenced this pull request Apr 12, 2023
@mergify @MichaelOrlov
Replace std::filesystem::path(..) with rcpputils::fs::path(..) (#…
9d64382 
…1104) (#1280)

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 6de3611)

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov mentioned this pull request Oct 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelOrlov @clalancette @emersonknapp