rosbag2_py: set defaults for config when bag rewriting

[james-rms]

Signed-off-by: James Smith james@foxglove.dev

Fixes #1119

[MichaelOrlov]

@james-rms Thanks for proposed fix.
LGTM.

[MichaelOrlov]

Gist: https://gist.githubusercontent.com/MichaelOrlov/37b035b3dac90791e769a837018b63ec/raw/838c31c160cc15706657ec6aecb273077a52baeb/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py ros2bag rosbag2_tests
TEST args: --packages-above rosbag2_py ros2bag rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10967

• Linux
• Linux-aarch64
• Windows

[MichaelOrlov]

@james-rms I see a lot of new warnings on Windows build about multiple inclusions of the YAML_CPP_DLL.
Those warnings supposed to be fixed in the #964

I am curios about if your branch behind the latest rolling and doesn't contain fixes from #964 ?
If so could you please rebase your branch on top of latest rolling branch?

[james-rms]

@MichaelOrlov I updated the patch to be type-safe, please let me know what you think.

[MichaelOrlov]

@james-rms I am sorry I don't get it.
What are you trying to solve with type safe update?
And what a difference when calling YAML::convert::decode(bag_node, record_options); explicitly?

[james-rms]

@MichaelOrlov here if compression_queue_size is removed or changes name, the code will no longer compile (rather than just setting a field on a YAML node that nobody reads).

[MichaelOrlov]

@james-rms Ok good. Can we do the same for StorageOptions?
auto storage_options = bag_node.as<rosbag2_storage::StorageOptions>();

[MichaelOrlov]

@james-rms BTW there are a couple new warnings from gcc
qualified-id in declaration before ‘(’ token 268 | YAML::convert::decode(bag_node, record_options); | ^
We need to address them before moving forward.

[MichaelOrlov]

Trying to re-run CI after updates:
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10974

• Linux
• Linux-aarch64
• Windows

[ros-discourse]

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-10-13/28213/1