Reader and writer can use default storage by not specifying #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
requested review from
MichaelOrlov and
jhdcs
and removed request for
a team
james-rms
approved these changes
Nov 18, 2022
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/b998440130e586b54d4cce57a4c7b4e1/raw/95d5a9f996440de5bd1ab712a08fbde6aff9962b/ros2.repos
|
|
Re-run Windows build, since failure
|
|
FYI, I kicked off the Windows build again (we were having some issues with CMake 3.25):
|
delete-merged-branch
bot
deleted the
emersonknapp/writer-default-storage
branch
|
Nice, possible to backport to humble ? |
|
https://github.com/Mergifyio backport humble |
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 5c4dafe) # Conflicts: # rosbag2_cpp/src/rosbag2_cpp/writer.cpp
✅ Backports have been created
|
MichaelOrlov
added a commit
that referenced
this pull request
Nov 22, 2022
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Nov 22, 2022
- Replaced `rosbag2_storage::get_default_storage_id()` with hardcoded kDefaultStorageID = "sqlite3" ssince we don't have `get_default_storage_id()` on `humble` Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Nov 23, 2022
…(backport #1167) (#1174) * Reader and writer can use default storage by not specifying (#1167) Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 5c4dafe) # Conflicts: # rosbag2_cpp/src/rosbag2_cpp/writer.cpp * Fix merge conflicts after backporting pr #1167 from rolling - Replaced `rosbag2_storage::get_default_storage_id()` with hardcoded kDefaultStorageID = "sqlite3" ssince we don't have `get_default_storage_id()` on `humble` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't hardcode anything for reader, as it can now autodetect.
Allow users to not specify a storage id for writer, in which case it will fall back to the default.
Closes #1158