-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader and writer can use default storage by not specifying #1167
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Gist: https://gist.githubusercontent.com/MichaelOrlov/b998440130e586b54d4cce57a4c7b4e1/raw/95d5a9f996440de5bd1ab712a08fbde6aff9962b/ros2.repos |
Nice, possible to backport to humble ? |
https://github.com/Mergifyio backport humble |
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 5c4dafe) # Conflicts: # rosbag2_cpp/src/rosbag2_cpp/writer.cpp
✅ Backports have been created
|
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
- Replaced `rosbag2_storage::get_default_storage_id()` with hardcoded kDefaultStorageID = "sqlite3" ssince we don't have `get_default_storage_id()` on `humble` Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
…(backport #1167) (#1174) * Reader and writer can use default storage by not specifying (#1167) Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit 5c4dafe) # Conflicts: # rosbag2_cpp/src/rosbag2_cpp/writer.cpp * Fix merge conflicts after backporting pr #1167 from rolling - Replaced `rosbag2_storage::get_default_storage_id()` with hardcoded kDefaultStorageID = "sqlite3" ssince we don't have `get_default_storage_id()` on `humble` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Don't hardcode anything for reader, as it can now autodetect.
Allow users to not specify a storage id for writer, in which case it will fall back to the default.
Closes #1158