Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix condition to only apply pragma for GCC 8+ #117

Merged
merged 1 commit into from
May 9, 2019
Merged

fix condition to only apply pragma for GCC 8+ #117

merged 1 commit into from
May 9, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented May 9, 2019 •
edited
Loading

Follow up of #116 (comment)

Linux: Build Status
CentOS: Build Status

@dirk-thomas
fix condition to only apply pragma for GCC 8+
70105fd 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review labels May 9, 2019
@dirk-thomas dirk-thomas self-assigned this May 9, 2019
Karsten1987
Karsten1987 approved these changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with green ci

@dirk-thomas dirk-thomas merged commit b34df98 into master May 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-build branch May 9, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @Karsten1987