Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more Writer methods in python interface #1220

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Expose more Writer methods in python interface #1220

merged 1 commit into from
Jan 9, 2023

Conversation

emersonknapp
Copy link
Collaborator

Just missing a few.

@emersonknapp
Expose more Writer methods in python interface
94ed28a 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp requested a review from a team as a code owner December 20, 2022 09:14
@emersonknapp emersonknapp requested review from MichaelOrlov and jhdcs and removed request for a team December 20, 2022 09:14
MichaelOrlov
MichaelOrlov approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.
Although I have a question in regards to the pybind11::overload_cast<..> usage.

rosbag2_py/src/rosbag2_py/_writer.cpp Show resolved Hide resolved
@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Dec 28, 2022 •
edited
Loading

Gist: https://gist.githubusercontent.com/emersonknapp/6cc4a0b28a01cde178eaa2a96144562f/raw/813c41abadd7e8e5c595e49c99a16eed8c9bfcd6/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp rosbag2_py
TEST args: --packages-above rosbag2_cpp rosbag2_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11318

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 7541eca into rolling Jan 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/py-writer-methods branch January 9, 2023 23:58
JannikJose pushed a commit to JannikJose/rosbag2 that referenced this pull request Oct 11, 2024
@emersonknapp @JannikJose
Expose more Writer methods in python interface (ros2#1220)
90ad4d2 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@JannikJose JannikJose mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersonknapp @MichaelOrlov