Parametrize all rosbag2_tests for both supported storage plugins #1221
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
requested review from
gbiggs,
hidmic and
james-rms
and removed request for
a team
| @@ -189,6 +189,7 @@ void Reindexer::aggregate_metadata( | |||
| rosbag2_cpp::ConverterOptions blank_converter_options {}; | |||
| bag_reader->open(temp_so, blank_converter_options); | |||
| auto temp_metadata = bag_reader->get_metadata(); | |||
| metadata_.storage_identifier = temp_metadata.storage_identifier; | |||
There was a problem hiding this comment.
Note: before this was leaving the storage ID blank in a reindex operation, if storage id not specified by user.
| @@ -42,7 +42,8 @@ if(BUILD_TESTING) | |||
|
|
|||
| ament_add_gmock(test_rosbag2_record_end_to_end | |||
| test/rosbag2_tests/test_rosbag2_record_end_to_end.cpp | |||
| WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) | |||
| WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} | |||
| TIMEOUT 120) | |||
There was a problem hiding this comment.
Note: new test suite just takes longer than the default minute, given the doubled number of tests
There was a problem hiding this comment.
It looks like this timeout needs to be increased further for this test to pass.
There was a problem hiding this comment.
I was wrong - there was a broken test which caused this suite to time out. I've pushed a commit to fix it.
| return test_name; | ||
| } | ||
|
|
||
| void create_test_bag(int messages_per_file, int num_files) |
Signed-off-by: James Smith <james@foxglove.dev>
james-rms
force-pushed
the
emersonknapp/parametrize-rosbag2-tests
branch
from
23e0b39
to
770ac09
Compare
|
Gist: https://gist.githubusercontent.com/james-rms/97f8ceec4535ad1bc1fa3f12784ad485/raw/f96b41102c6f6cbb1691ee95a871adcc247eed56/ros2.repos
|
delete-merged-branch
bot
deleted the
emersonknapp/parametrize-rosbag2-tests
branch
Related to #1160
This way when both plugins are shipped by default, the full integration test suite is run on both.