Fix expectations for rosbag2 return code in rosbag2_performance_benchmarking #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past we had return code 2 for rosbag2 when interrupting by CTRL+C Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
emersonknapp and
jhdcs
and removed request for
a team
emersonknapp
approved these changes
Mar 22, 2023
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
delete-merged-branch
bot
deleted the
morlov/fix_rosbag2_performance_benchmarking_failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we had return code 2 for rosbag2 when interrupting by CTRL+C.
Although we have changed behavior and now returning 0 and seems forgotten to change expectation in
rosbag2_performance_benchmarkingpackage.