Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong descritpion for '--ignore-leaf-topics' #1344

Merged
merged 1 commit into from May 23, 2023
Merged

Fix wrong descritpion for '--ignore-leaf-topics' #1344

merged 1 commit into from May 23, 2023

Conversation

Barry-Xu-2018
Copy link
Contributor

Address #1343

@Barry-Xu-2018
Fix wrong descritpion for '--ignore-leaf-topics'
d899c72 
Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 Barry-Xu-2018 requested a review from a team as a code owner May 22, 2023 07:32
@Barry-Xu-2018 Barry-Xu-2018 requested review from emersonknapp and jhdcs and removed request for a team May 22, 2023 07:32
@fujitatomoya
Copy link
Contributor

@MichaelOrlov just doc fix, friendly ping.

CC: @emersonknapp

@emersonknapp emersonknapp merged commit 92fa887 into ros2:rolling May 23, 2023
14 checks passed
@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request May 23, 2023
Closed
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport iron

@mergify
Copy link

mergify bot commented May 23, 2023 •
edited

backport iron

✅ Backports have been created

@mergify mergify bot mentioned this pull request May 23, 2023
Merged
mergify bot pushed a commit that referenced this pull request May 23, 2023
@Barry-Xu-2018 @mergify
Fix wrong descritpion for '--ignore-leaf-topics' (#1344)
4ad22d5 
Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit 92fa887)
MichaelOrlov pushed a commit that referenced this pull request May 23, 2023
@mergify @Barry-Xu-2018
Fix wrong descritpion for '--ignore-leaf-topics' (#1344) (#1345)
94ad7ba 
Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit 92fa887)

Co-authored-by: Barry Xu <barry.xu@sony.com>
@emersonknapp emersonknapp mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Barry-Xu-2018 @fujitatomoya @MichaelOrlov @emersonknapp