Remove rcpputils::fs dependencies from rosbag2_storages #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original author: Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>
r7vme
requested review from
emersonknapp and
hidmic
and removed request for
a team
Co-authored with Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>
|
@MichaelOrlov could you please take a look? |
r7vme
commented
Jan 31, 2024
|
CI:
|
|
@r7vme There are quite a few linter failures here. Please run the linters locally and fix the problems, then we can try again. |
Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>
|
@clalancette fixed tests, PTAL |
|
CI:
|
clalancette
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
This looks good to me, but I'd like another opinion from @MichaelOrlov before we merge.
MichaelOrlov
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
@r7vme Thanks for the contribution. The changes looks good to me.
However, there is one open question for the future.
Do we really need to use the ".generic_string()" or simple .string() would be enough?
Someone is going to have to test it out on Windows to tell for sure. |
|
As far as I understand from documentation the one should use |
|
https://github.com/Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Remove rcpputils::fs dependencies from rosbag2_storages Original author: Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Use path::generic_string() for Windows compatibility Co-authored with Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Fix linter errors in osbag2_storage_sqlite3 Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Co-authored-by: Kenta Yonekura <yoneken@ieee.org> (cherry picked from commit edda376) # Conflicts: # rosbag2_storage_mcap/test/rosbag2_storage_mcap/test_mcap_storage.cpp # rosbag2_storage_sqlite3/src/rosbag2_storage_sqlite3/sqlite_storage.cpp # rosbag2_storage_sqlite3/test/rosbag2_storage_sqlite3/test_sqlite_storage.cpp
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Remove rcpputils::fs dependencies from rosbag2_storages Original author: Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Use path::generic_string() for Windows compatibility Co-authored with Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Fix linter errors in osbag2_storage_sqlite3 Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Co-authored-by: Kenta Yonekura <yoneken@ieee.org> (cherry picked from commit edda376) # Conflicts: # rosbag2_storage/CMakeLists.txt # rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp # rosbag2_storage_default_plugins/test/rosbag2_storage_default_plugins/sqlite/test_sqlite_storage.cpp # rosbag2_storage_mcap/test/rosbag2_storage_mcap/test_mcap_storage.cpp
MichaelOrlov
added a commit
that referenced
this pull request
Feb 3, 2024
…ort #1558) (#1564) * Remove rcpputils::fs dependencies from rosbag2_storages (#1558) * Remove rcpputils::fs dependencies from rosbag2_storages Original author: Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Use path::generic_string() for Windows compatibility Co-authored with Kenta Yonekura <yoneken@ieee.org> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Fix linter errors in osbag2_storage_sqlite3 Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Co-authored-by: Kenta Yonekura <yoneken@ieee.org> (cherry picked from commit edda376) # Conflicts: # rosbag2_storage_mcap/test/rosbag2_storage_mcap/test_mcap_storage.cpp # rosbag2_storage_sqlite3/src/rosbag2_storage_sqlite3/sqlite_storage.cpp # rosbag2_storage_sqlite3/test/rosbag2_storage_sqlite3/test_sqlite_storage.cpp * Resolve merge conflicts Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Update rosbag2_storage_sqlite3 to C++17. (#1501) Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 9855072) --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Roman <rsokolkov@gmail.com> Co-authored-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original author: Kenta Yonekura yoneken@ieee.org
Copy of stalled PR #1474