Add get_identifier to io-interfaces for support in bagfile splitting #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmichaels11
force-pushed
the
splitting/io-interfaces-get-identifier
branch
2 times, most recently
from
f37772f
to
646a74e
Compare
This was referenced Oct 17, 2019
Karsten1987
reviewed
Oct 18, 2019
...g2_storage_default_plugins/include/rosbag2_storage_default_plugins/sqlite/sqlite_storage.hpp
Outdated
Show resolved
Hide resolved
zmichaels11
force-pushed
the
splitting/io-interfaces-get-identifier
branch
from
646a74e
to
003687e
Compare
2 tasks
zmichaels11
force-pushed
the
splitting/io-interfaces-get-identifier
branch
2 times, most recently
from
9f0131b
to
d432ab1
Compare
|
@Karsten1987 this one's next. |
Karsten1987
reviewed
Oct 21, 2019
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp
Show resolved
Hide resolved
Karsten1987
reviewed
Oct 21, 2019
rosbag2_storage/include/rosbag2_storage/storage_interfaces/base_io_interface.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
splitting/io-interfaces-get-identifier
branch
from
d432ab1
to
a68c354
Compare
|
@Karsten1987 applied suggestions and rebased onto master |
|
Karsten1987
approved these changes
Oct 21, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an effort to rework PR #158 into multiple, smaller PRs.
Changes
get_identifiertoBaseIOInterface. This will be used byWriterto generate theBagMetadatawithout requiring merging of the metadata returned by each sub-bagfile in the splitting process.Dependent PRs
Issues