Expose topic filter to command line (addresses #342)

[mabelzhang]

Addresses #342. Exposes reader topic filter to command line playback.

The test added in test_rosbag2_play_end_to_end.cpp depends on #362.
Usage:

ros2 bag play cdr_test --topics /test_topic
ros2 bag play --topics /array_topic -- cdr_test

[piraka9011]

One more request, but overall LGTM pending green CI (ament_export warning is fine...)

[Karsten1987]

lgtm with green CI

[Karsten1987]

Suggested change

	std::vector<std::string> topics_to_filter = std::vector<std::string>();
	std::vector<std::string> topics_to_filter ={};

[emersonknapp]

std::vector<std::string> topics_to_filter{}

[piraka9011]

Or just std::vector<std::string> topics_to_filter{};

[Karsten1987]

just adapting to the style below for the std::unordered_map ;-)

[mabelzhang]

Heh, so I already changed to {} without the = so now they're inconsistent. Do we prefer changing the line below too, or change back to ={}?

[mabelzhang]

My local workspace is very broken. I need to fix it before I can compile locally before trying CI again.

[emersonknapp]

I recommend a docker-based workflow. Here's the Dockerfile I personally use https://github.com/emersonknapp/ros2containerbuild/blob/master/Dockerfile and use via

rocker \
  --x11 \
  --network host \
  --oyr-run-arg "--name SOMETHING --rm -v $PWD:/ws -w /ws" \
  candleends/ros2dev

Workspace always clean and portable :)

[mabelzhang]

Yeah... I do develop in Docker containers normally, but the one I've been using is built from eloquent source, and with the recent volume of changes, I'm not able to just pull a few packages from master branch and compile. So I'm making a new Docker image, probably not unlike yours, that pulls ros2.repos from the master branch instead.

[emersonknapp]

I did not intend to close this... no idea how i did

[mabelzhang]

Darn. I thought there was no more work for me ;)

[mabelzhang]

There are two CI test failures on Linux that I don't understand, projectroot.test_record_all__rmw_fastrtps_cpp and rosbag2_transport.RecordIntegrationTestFixture.published_messages_from_multiple_topics_are_recorded. They're printing binary bites. Still waiting for macOS and Windows.

• Linux
• Linux-aarch64
• macOS
• Windows

[mabelzhang]

macOS has the same test failures as Linux, and Windows has some record test failures.

[emersonknapp]

See #376 (comment) - my current hypothesis is that there is a bug in Fast-RTPS right now...

[mabelzhang]

No more test failures in Linux and macOS. Waiting for Windows

• Linux
• Linux-aarch64
• macOS
• Windows

[mabelzhang]

Windows tests look okay too. Only the known record split bag failures.