Shared publisher handle. #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ivanpauno
approved these changes
May 27, 2020
emersonknapp
approved these changes
May 28, 2020
jacobperron
approved these changes
May 28, 2020
pjreed
pushed a commit
to pjreed/rosbag2
that referenced
this pull request
May 28, 2020
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: P. J. Reed <preed@swri.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Switch to getting the raw handle since
get_publisher_handlenow returns a shared_ptr.Goes along with ros2/rclcpp#1119 ; more discussion and CI is there.