minimal c++ API test #451
Merged
minimal c++ API test #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Merged
emersonknapp
approved these changes
Jul 10, 2020
|
running CI before merging:
|
|
GH actions are showing the linters being fixed. Merging. |
|
The Windows CI build shows a compiler warning (https://ci.ros2.org/job/ci_windows/11319/msbuild/) which is also present in the last nightly builds. |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-07-16/15468/1 |
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
* minimal c++ API test Signed-off-by: Karsten Knese <karsten@openrobotics.org> * linters Signed-off-by: Karsten Knese <karsten@openrobotics.org>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
* minimal c++ API test Signed-off-by: Karsten Knese <karsten@openrobotics.org> * linters Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a first step into improving the general C++ API for writing and reading rosbags.
The set of API calls in the test are the minimal set I could come up with in order to write a MessageT into the bag file. IMHO, there's quite some room for making this more user friendly.
SequentialReaderandSequentialWriterthe default implementation. That would allow forrosbag2_cpp::Writer writer;to simply work.openwith only specifying theStorageOptionsshould suffice and the converter functionality should be bypassed as such.unknown file: Failure C++ exception with description "unordered_map::at: key not found" thrown in the test body.I've addressed that in this PR.malloc: *** error for object 0x7ffeefbfdc88: pointer being freed was not allocated).