-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rpyutils import_c_library function for rosbag2_transport_py #482
Conversation
…thon Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Since library loading can sometimes misbehave on Windows Debug, added a CI run specifically testing it. |
@emersonknapp this branch can be deleted, I think. |
Also, the URL should be corrected in older/existing distros. I guess this PR can't really be used to be backported, can it? |
Ah - this I didn't think all the way through - we could backport this only into Foxy because rpyutils was added in that distro. What do you think about a single backport patch commit to Foxy, Eloquent, and Dashing that just copies the contents of the new rpyutils function? |
I think it makes sense to backport this PR to Foxy. For Eloquent and Dashing I would actually really just change the URL. |
…thon (#482) Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Use rpyutils import_c_library function for rosbag2_transport_py - instead of re-defining the logic here (with outdated information)
Depends on ros2/rpyutils#4
Closes #445