Removed duplicated code in record #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabonnie
reviewed
Oct 7, 2020
dabonnie
approved these changes
Oct 7, 2020
dabonnie
reviewed
Oct 7, 2020
dabonnie
approved these changes
Oct 7, 2020
jaisontj
force-pushed
the
jaisontj/clirecord-cleanup
branch
2 times, most recently
from
5c217ce
to
3380867
Compare
Signed-off-by: Jaison Titus <jaisontj@amazon.com>
Signed-off-by: Jaison Titus <jaisontj@amazon.com>
record function. Signed-off-by: Jaison Titus <jaisontj@amazon.com>
Co-authored-by: Devin Bonnie <47613035+dabonnie@users.noreply.github.com>
then the cli help message is printed to std out. Signed-off-by: Jaison Titus <jaisontj@amazon.com>
Signed-off-by: Jaison Titus <jaisontj@amazon.com>
jaisontj
force-pushed
the
jaisontj/clirecord-cleanup
branch
from
3380867
to
bb412a2
Compare
|
Running CI build_args:
|
|
The instability looks unrelated to the PR and related to the failing xmllint tests that are happening in the nightly as well. |
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Removed duplicated code for record. Signed-off-by: Jaison Titus <jaisontj@amazon.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
* Removed duplicated code for record. Signed-off-by: Jaison Titus <jaisontj@amazon.com>
skudryas
pushed a commit
to skudryas/rosbag2
that referenced
this pull request
Mar 12, 2021
* Removed duplicated code for record. Signed-off-by: Jaison Titus <jaisontj@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some duplicated code in rosbag2/record.py that can be cleaned up.