-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back rosbag2_cpp::StorageOptions as deprecated #563
Conversation
The struct was removed in #493, but in order to avoid a hard-break for users coming from Foxy I've added it back with a deprecation warning. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
So I was cloning and building package from source using the instructions in the Readme.md . It both fails on
Full: Could be I am missing something trivial as well.... |
Seems that sqlite_storage.hpp is missing
but this is not the only thing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me with CI.
@agutenkunst are you building this on a foxy overlay or are you building all of ros2 from source? This sounds like as if you have a rosbag2 debian installation in your path as well. The storage options are available in the rosbag2_storage package, yet it looks like your include paths are pointing so something else. |
Hi @Karsten19 So I am pretty new at ROS2 (as you might figured) I thought that something like this could be the issue, yet if I check the
which looks fine at first glance but maybe I am missing something here? I do not mean to hold the PR! |
@agutenkunst as you can see you have You could try to deinstall your Foxy rosbag2 installation, but that's definitely not a supported use-case. If you still encounter that problem, I would recommend you open a separate ticket or ask the question on ros-answers. |
The struct was removed in #493, but in order to avoid a hard-break for users coming from Foxy I've added it back with a deprecation warning. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
The struct was removed in #493, but in order to avoid a hard-break for users coming from Foxy I've added it back with a deprecation warning. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
The struct was removed in #493, but in order
to avoid a hard-break for users coming from Foxy I've added it back with a deprecation
warning.