Add back rosbag2_cpp::StorageOptions as deprecated

[jacobperron]

The struct was removed in #493, but in order
to avoid a hard-break for users coming from Foxy I've added it back with a deprecation
warning.

[agutenkunst]

So I was cloning and building package from source using the instructions in the Readme.md . It both fails on master and on this PR with:

--- stderr: rosbag2_storage_default_plugins                                                                                                        
In file included from /home/alex/ros2_ws_slam/src/rosbag2/rosbag2_storage_default_plugins/test/rosbag2_storage_default_plugins/sqlite/storage_test_fixture.hpp:36,
                 from /home/alex/ros2_ws_slam/src/rosbag2/rosbag2_storage_default_plugins/test/rosbag2_storage_default_plugins/sqlite/test_sqlite_wrapper.cpp:27:
/home/alex/ros2_ws_slam/src/rosbag2/rosbag2_storage_default_plugins/include/rosbag2_storage_default_plugins/sqlite/sqlite_storage.hpp:52:28: error: ‘StorageOptions’ in namespace ‘rosbag2_storage’ does not name a type
   52 |     const rosbag2_storage::StorageOptions & storage_options,
      |                            ^~~~~~~~~~~~~~
In file included from /home/alex/ros2_ws_slam/src/rosbag2/rosbag2_storage_default_plugins/test/rosbag2_storage_default_plugins/sqlite/storage_test_fixture.hpp:36,
                 from /home/alex/ros2_ws_slam/src/rosbag2/rosbag2_storage_default_plugins/test/rosbag2_storage_default_plugins/sqlite/test_sqlite_storage.cpp:29:
/home/alex/ros2_ws_slam/src/rosbag2/rosbag2_storage_default_plugins/include/rosbag2_storage_default_plugins/sqlite/sqlite_storage.hpp:52:28: error: ‘StorageOptions’ in namespace ‘rosbag2_storage’ does not name a type
   52 |     const rosbag2_storage::StorageOptions & storage_options,


[...]

Full:
err.txt

Could be I am missing something trivial as well....

[agutenkunst]

Seems that sqlite_storage.hpp is missing

#include "rosbag2_storage/storage_options.hpp"

but this is not the only thing...

[Karsten1987]

works for me with CI.

[Karsten1987]

@agutenkunst are you building this on a foxy overlay or are you building all of ros2 from source? This sounds like as if you have a rosbag2 debian installation in your path as well. The storage options are available in the rosbag2_storage package, yet it looks like your include paths are pointing so something else.

[agutenkunst]

Hi @Karsten19

So I am pretty new at ROS2 (as you might figured) I thought that something like this could be the issue, yet if I check the AMENT_PREFIX_PATH it states

/home/alex/ros2_ws_slam/install/rosbag2:/home/alex/ros2_ws_slam/install/ros2bag:/home/alex/ros2_ws_slam/install/rosbag2_transport:/home/alex/ros2_ws_slam/install/rosbag2_compression:/home/alex/ros2_ws_slam/install/zstd_vendor:/home/alex/ros2_ws_slam/install/rosbag2_storage_default_plugins:/opt/ros/foxy

which looks fine at first glance but maybe I am missing something here?

I do not mean to hold the PR!

[Karsten1987]

@agutenkunst as you can see you have /opt/ros/foxy within your path. I wouldn't be surprised if you have the Foxy installation of rosbag2 found first and don't use the include directories of the overlay. Please also be aware that there's no guarantee that a master build of rosbag2 works on a Foxy underlay installation.

You could try to deinstall your Foxy rosbag2 installation, but that's definitely not a supported use-case. If you still encounter that problem, I would recommend you open a separate ticket or ask the question on ros-answers.

[jacobperron]

• Linux
• Linux-aarch64
• macOS
• Windows