Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rosbag2_py::Player::play to replace rosbag2_transport_python version #693

Merged
merged 4 commits into from
Mar 30, 2021
Merged

Add rosbag2_py::Player::play to replace rosbag2_transport_python version #693

merged 4 commits into from
Mar 30, 2021

Conversation

emersonknapp
Copy link
Collaborator

"record" is an easy followup if we like this pattern.

As I'm preparing to add more playback arguments, I don't want to manage the PyArg_ParseTupleAndKeywords monster anymore

@emersonknapp emersonknapp marked this pull request as ready for review March 25, 2021 22:54
@emersonknapp emersonknapp requested a review from a team as a code owner March 25, 2021 22:54
@emersonknapp emersonknapp requested review from jaisontj and removed request for a team March 25, 2021 22:54
emersonknapp pushed a commit that referenced this pull request Mar 26, 2021
Clock publisher in Player
c563f42 
Fixes #99
Design: #675
Depends on #689
Depends on #693 to expose to the CLI

Add a `rosgraph_msgs/Clock` publisher to the `Player` - that uses `PlayerClock::now()` to publish current time.

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This was referenced Mar 26, 2021
Merged
Closed
Emerson Knapp added 4 commits March 26, 2021 16:31
Add rosbag2_py::Transport::play to replace rosbag2_transport_python v…
f39a20e 
…ersion

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Fix linters
c3d3bfa 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Remove printfs
c36ebd4 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Rename exposed pybind class as Player in anticipation of braeking up …
bf0f852 
…Rosbag2Transport

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/ros2bag-play-pybind branch from 54e9887 to bf0f852 Compare March 26, 2021 23:31
@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Mar 26, 2021 •
edited
Loading

Gist: https://gist.githubusercontent.com/emersonknapp/65fb16be65c57a7a6f0ed2efec5f12a5/raw/8bc9675254d9aa9bbf2a0cc66798aa03e88ea595/ros2.repos
BUILD args: --packages-up-to rosbag2_transport rosbag2_tests ros2bag rosbag2_py
TEST args: --packages-select rosbag2_transport rosbag2_tests ros2bag rosbag2_py
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8000

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp changed the title Add rosbag2_py::Transport::play to replace rosbag2_transport_python version Add rosbag2_py::Player::play to replace rosbag2_transport_python version Mar 26, 2021
@emersonknapp emersonknapp mentioned this pull request Mar 27, 2021
Closed
@emersonknapp emersonknapp merged commit 2f30a78 into master Mar 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/ros2bag-play-pybind branch March 30, 2021 22:01
@emersonknapp emersonknapp mentioned this pull request Mar 31, 2021
Merged
emersonknapp pushed a commit that referenced this pull request Mar 31, 2021
Clock publisher in Player
009c60d 
Fixes #99
Design: #675
Depends on #689
Depends on #693 to expose to the CLI

Add a `rosgraph_msgs/Clock` publisher to the `Player` - that uses `PlayerClock::now()` to publish current time.

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaisontj jaisontj jaisontj approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

@anuragdmadan anuragdmadan Awaiting requested review from anuragdmadan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersonknapp @jaisontj