Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use rclcpp::Node for generic pub/sub #714

Merged
merged 3 commits into from
Apr 6, 2021
Merged

use rclcpp::Node for generic pub/sub #714

merged 3 commits into from
Apr 6, 2021

Conversation

Karsten1987
Copy link
Collaborator

There were some functions for topic expansion and filtering on the rosbag2node which I moved into a new class TopicFilter.

@Karsten1987
use rclcpp::Node for generic pub/sub
2356531 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987 Karsten1987 requested a review from a team as a code owner April 6, 2021 00:32
@Karsten1987 Karsten1987 requested review from emersonknapp and david-prody and removed request for a team April 6, 2021 00:32
emersonknapp
emersonknapp approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major complaints - this is a satisfying diff :)

rosbag2_transport/src/rosbag2_transport/topic_filter.hpp Outdated Show resolved Hide resolved
rosbag2_transport/src/rosbag2_transport/topic_filter.cpp Show resolved Hide resolved
rosbag2_transport/src/rosbag2_transport/topic_filter.cpp Outdated Show resolved Hide resolved
rosbag2_transport/src/rosbag2_transport/topic_filter.hpp Show resolved Hide resolved
rosbag2_transport/test/rosbag2_transport/test_topic_filter.cpp Outdated Show resolved Hide resolved
rosbag2_transport/test/rosbag2_transport/test_topic_filter.cpp Outdated Show resolved Hide resolved
@Karsten1987 Karsten1987 mentioned this pull request Apr 6, 2021
Merged
@Karsten1987
address review comments
8ecc399 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987
Copy link
Collaborator Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
export symbols on windows
2737829 
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987
Copy link
Collaborator Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
Copy link
Collaborator Author

Windows warning is unrelated, comes from cyclonedds.

@Karsten1987 Karsten1987 merged commit 8d50078 into master Apr 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the use_rclcpp_generic_pubsub branch April 6, 2021 05:29
@emersonknapp emersonknapp mentioned this pull request Apr 7, 2021
Closed
50 tasks
Kettenhoax pushed a commit to Kettenhoax/rosbag2 that referenced this pull request Apr 9, 2021
@Karsten1987
use rclcpp::Node for generic pub/sub (ros2#714)
3a29279 
* use rclcpp::Node for generic pub/sub

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>

* address review comments

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>

* export symbols on windows

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@david-prody david-prody Awaiting requested review from david-prody

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karsten1987 @emersonknapp